fix(core): backfill OpenAI responses model in spans#19810
Open
meronogbai wants to merge 2 commits intogetsentry:developfrom
Open
fix(core): backfill OpenAI responses model in spans#19810meronogbai wants to merge 2 commits intogetsentry:developfrom
meronogbai wants to merge 2 commits intogetsentry:developfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
57deae1 to
30ee31b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
OpenAI Responses API calls can omit model in the request payload when using stored prompts. In that case, Sentry currently records gen_ai.request.model = "unknown" even though the final OpenAI response includes the actual model.
This change keeps the existing request-time fallback behavior, but overwrites the request model from response.model once the Responses API response arrives. It also updates the span name from chat unknown to chat .
This is now handled for both:
Agents dashboard screenshots
In production where this change isn't applied:
In development where this change was applied manually:
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Closes #issue_link_here