Skip to content

feat: Expose iOS options to ignore views from subtree traversal #5545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antonis merged 3 commits into from
Jan 16, 2026
Merged

feat: Expose iOS options to ignore views from subtree traversal #5545

antonis merged 3 commits into from
Jan 16, 2026
+111 −1

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Jan 16, 2026 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Exposes iOS options to ignore views from subtree traversal to prevent crashes when traversing problematic view hierarchies during session replay and screenshot capture.
This was added in iOS with getsentry/sentry-cocoa#7063 in https://github.com/getsentry/sentry-cocoa/releases/tag/8.58.0

💡 Motivation and Context

Fixes #5525

💚 How did you test it?

Manual, Unit tests

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis antonis added the ready-to-merge Triggers the full CI test suite label Jan 16, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026 •
edited
Loading

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

  • feat: Expose iOS options to ignore views from subtree traversal by antonis in #5545
  • Experimental: Android UI profiling by alwx in #5518
  • chore(deps): update Android SDK to v8.30.0 by github-actions in #5539
  • fix(replay): Fix traces not always being attached to replays with errors by antonis in #5538
  • fix(ios): Fix duplicate JS error reporting on iOS with New Architecture by antonis in #5532
  • chore(deps): update Bundler Plugins to v4.6.2 by github-actions in #5536
  • chore(deps): update JavaScript SDK to v10.34.0 by github-actions in #5535
  • chore(deps): bump undici from 6.21.3 to 6.23.0 by dependabot in #5533
  • chore(deps): update Cocoa SDK to v8.58.0 by antonis in #5524
  • chore(deps): update Maestro to v2.1.0 by github-actions in #5521
  • chore(deps): update JavaScript SDK to v10.33.0 by github-actions in #5522
  • Fix: Update changelog-preview workflow reference by lucas-zimerman in #5527
  • ci(release): Switch from action-prepare-release to Craft by BYK in #5519
  • chore(deps): update Wizard to v6.11.0 by github-actions in #5520
  • fix(appstart): Skip span ID check when standalone mode is enabled by antonis in #5493
  • chore(deps): update JavaScript SDK to v10.32.1 by github-actions in #5496
  • chore(deps): bump aws-sdk-s3 from 1.169.0 to 1.208.0 in /samples/react-native by dependabot in #5498
  • chore(deps): bump github/codeql-action from 4.31.8 to 4.31.9 by dependabot in #5497
  • chore(deps): bump aws-sdk-s3 from 1.203.0 to 1.208.0 in /performance-tests by dependabot in #5491
  • chore(deps): bump aws-sdk-s3 from 1.169.0 to 1.208.0 in /samples/react-native-macos by dependabot in #5490
  • chore(deps): update JavaScript SDK to v10.32.0 by github-actions in #5487
  • Fix for missing replay_id from metrics by alwx in #5483
  • chore(deps): update Wizard to v6.10.0 by github-actions in #5474
  • Bump e2e tests to XCode 26 by alwx in #5467

Plus 1 more

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 62178a5

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 451.46 ms 476.14 ms 24.68 ms
Size 43.75 MiB 48.55 MiB 4.80 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
01d24f6+dirty 362.50 ms 362.23 ms -0.27 ms
8ff81c0+dirty 574.58 ms 611.44 ms 36.86 ms
07808fb+dirty 419.10 ms 419.08 ms -0.02 ms
f234eb4+dirty 407.62 ms 429.64 ms 22.02 ms
c08359e 421.87 ms 445.37 ms 23.50 ms
a3f3291+dirty 414.59 ms 422.76 ms 8.16 ms
6fee48d+dirty 407.42 ms 437.71 ms 30.29 ms
98f632c 424.25 ms 435.48 ms 11.23 ms
c73f7cc+dirty 494.17 ms 528.02 ms 33.86 ms
7e9c42c+dirty 513.69 ms 517.50 ms 3.81 ms

App size

Revision Plain With Sentry Diff
01d24f6+dirty 17.75 MiB 19.74 MiB 2.00 MiB
8ff81c0+dirty 43.75 MiB 48.05 MiB 4.29 MiB
07808fb+dirty 17.75 MiB 19.70 MiB 1.95 MiB
f234eb4+dirty 17.75 MiB 19.74 MiB 1.99 MiB
c08359e 17.75 MiB 20.15 MiB 2.41 MiB
a3f3291+dirty 43.75 MiB 48.07 MiB 4.32 MiB
6fee48d+dirty 17.75 MiB 19.68 MiB 1.94 MiB
98f632c 17.75 MiB 20.15 MiB 2.41 MiB
c73f7cc+dirty 43.75 MiB 48.09 MiB 4.34 MiB
7e9c42c+dirty 43.75 MiB 48.02 MiB 4.27 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 406.29 ms 444.29 ms 38.00 ms
Size 43.94 MiB 49.38 MiB 5.44 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c4e097a+dirty 382.43 ms 443.77 ms 61.34 ms
9f211e3+dirty 371.00 ms 432.51 ms 61.51 ms
8ff81c0+dirty 392.47 ms 431.52 ms 39.05 ms
a3f3291+dirty 399.06 ms 432.43 ms 33.36 ms
c73f7cc+dirty 371.53 ms 378.44 ms 6.91 ms
7e9c42c+dirty 362.94 ms 375.58 ms 12.65 ms
170d5ea+dirty 348.79 ms 406.94 ms 58.15 ms
7091004+dirty 377.76 ms 402.11 ms 24.35 ms
652f785+dirty 367.80 ms 390.71 ms 22.91 ms
294387d+dirty 359.44 ms 393.40 ms 33.97 ms

App size

Revision Plain With Sentry Diff
c4e097a+dirty 7.15 MiB 8.41 MiB 1.26 MiB
9f211e3+dirty 7.15 MiB 8.41 MiB 1.26 MiB
8ff81c0+dirty 43.94 MiB 48.87 MiB 4.93 MiB
a3f3291+dirty 43.94 MiB 48.90 MiB 4.96 MiB
c73f7cc+dirty 43.94 MiB 48.92 MiB 4.98 MiB
7e9c42c+dirty 43.94 MiB 48.85 MiB 4.91 MiB
170d5ea+dirty 7.15 MiB 8.42 MiB 1.27 MiB
7091004+dirty 43.94 MiB 48.81 MiB 4.88 MiB
652f785+dirty 43.94 MiB 48.82 MiB 4.88 MiB
294387d+dirty 43.94 MiB 48.87 MiB 4.93 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1199.55 ms 1211.38 ms 11.83 ms
Size 3.38 MiB 4.60 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
46da307+dirty 1213.45 ms 1207.96 ms -5.49 ms
bb4ea33+dirty 1223.90 ms 1217.83 ms -6.06 ms
161947d+dirty 1203.45 ms 1217.83 ms 14.38 ms
8d89cc9+dirty 1232.35 ms 1228.53 ms -3.82 ms
e2fa43d+dirty 1224.43 ms 1235.40 ms 10.98 ms
083f560+dirty 1215.27 ms 1231.96 ms 16.69 ms
f3b058c+dirty 1221.43 ms 1219.85 ms -1.58 ms
ec14be7+dirty 1229.62 ms 1230.53 ms 0.91 ms
c08359e+dirty 1200.59 ms 1211.81 ms 11.22 ms
9f211e3+dirty 1215.38 ms 1218.15 ms 2.77 ms

App size

Revision Plain With Sentry Diff
46da307+dirty 3.19 MiB 4.44 MiB 1.25 MiB
bb4ea33+dirty 3.44 MiB 4.59 MiB 1.15 MiB
161947d+dirty 3.19 MiB 4.56 MiB 1.37 MiB
8d89cc9+dirty 3.19 MiB 4.53 MiB 1.35 MiB
e2fa43d+dirty 3.19 MiB 4.38 MiB 1.19 MiB
083f560+dirty 3.19 MiB 4.56 MiB 1.38 MiB
f3b058c+dirty 3.41 MiB 4.67 MiB 1.25 MiB
ec14be7+dirty 3.19 MiB 4.54 MiB 1.36 MiB
c08359e+dirty 3.19 MiB 4.38 MiB 1.19 MiB
9f211e3+dirty 3.19 MiB 4.48 MiB 1.29 MiB

@antonis
Copy link
Contributor Author

antonis commented Jan 16, 2026

@sentry review

@antonis antonis marked this pull request as ready for review January 16, 2026 10:10
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.45 ms 1218.73 ms 3.28 ms
Size 3.38 MiB 4.60 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
46da307+dirty 1217.08 ms 1224.16 ms 7.08 ms
bb4ea33+dirty 1208.98 ms 1218.50 ms 9.52 ms
161947d+dirty 1203.43 ms 1217.00 ms 13.57 ms
8d89cc9+dirty 1222.92 ms 1239.43 ms 16.51 ms
e2fa43d+dirty 1216.04 ms 1232.65 ms 16.61 ms
083f560+dirty 1227.33 ms 1242.02 ms 14.69 ms
f3b058c+dirty 1221.30 ms 1214.62 ms -6.68 ms
ec14be7+dirty 1234.64 ms 1245.54 ms 10.90 ms
c08359e+dirty 1235.25 ms 1233.96 ms -1.29 ms
9f211e3+dirty 1218.80 ms 1233.88 ms 15.08 ms

App size

Revision Plain With Sentry Diff
46da307+dirty 2.63 MiB 3.87 MiB 1.24 MiB
bb4ea33+dirty 3.44 MiB 4.59 MiB 1.15 MiB
161947d+dirty 2.63 MiB 3.99 MiB 1.36 MiB
8d89cc9+dirty 2.63 MiB 3.96 MiB 1.33 MiB
e2fa43d+dirty 2.63 MiB 3.81 MiB 1.18 MiB
083f560+dirty 2.63 MiB 4.00 MiB 1.36 MiB
f3b058c+dirty 3.41 MiB 4.67 MiB 1.25 MiB
ec14be7+dirty 2.63 MiB 3.98 MiB 1.34 MiB
c08359e+dirty 2.63 MiB 3.81 MiB 1.18 MiB
9f211e3+dirty 2.63 MiB 3.91 MiB 1.28 MiB

alwx
alwx approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@alwx alwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonis antonis merged commit 4997892 into main Jan 16, 2026
81 of 82 checks passed
@antonis antonis deleted the antonis/ios-exclude-views branch January 16, 2026 11:10
@sentry-release-bot sentry-release-bot bot mentioned this pull request Jan 16, 2026
Closed
3 tasks
@antonis antonis mentioned this pull request Jan 16, 2026
Merged
6 tasks
antonis added a commit to getsentry/sentry-docs that referenced this pull request Jan 16, 2026
@antonis @lucas-zimerman
React Native: Add iOS session replay view filtering documentation (#1…
51ca0f5 
…6052)

<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->

## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*

Adds documentation for
getsentry/sentry-react-native#5545

## IS YOUR CHANGE URGENT?  

Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!

## PRE-MERGE CHECKLIST

*Make sure you've checked the following before merging your changes:*

- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

## LEGAL BOILERPLATE

<!-- Sentry employees and contractors can delete or ignore this section.
-->

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

## EXTRA RESOURCES

- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)

---------

Co-authored-by: LucasZF <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alwx alwx alwx approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees

No one assigned

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose iOS options to ignore views from subtree traversal

3 participants

@antonis @alwx