Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Jan 16, 2026

Summary

Updates the changelog-preview workflow to use pull_request_target instead of pull_request.

Why?

This change is required for the changelog preview to work correctly with PRs from forks. With pull_request, the workflow runs with a read-only GITHUB_TOKEN which cannot post comments or create statuses on fork PRs.

This aligns with the recommended usage in the craft changelog-preview workflow.

Security Note

This change is safe because the changelog-preview workflow:

  • Downloads the Craft binary from releases (not from the PR)
  • Only reads git metadata and configuration
  • Does not execute any code from the PR

@github-actions
Copy link
Contributor

Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against d33da98

@BYK BYK enabled auto-merge (squash) January 16, 2026 12:57
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Thank you Burak 🙇

@BYK BYK merged commit 80e4616 into main Jan 16, 2026
38 of 43 checks passed
@BYK BYK deleted the chore/changelog-preview-target branch January 16, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants