[GHSA-6wpv-cj6x-v3jw] http vulnerable to Exposure of Sensitive Information to an Unauthorized Actor#7405
Open
tjuyuxinzhang wants to merge 1 commit intotjuyuxinzhang/advisory-improvement-7405from
Conversation
Contributor
|
Hi @tjuyuxinzhang, this is an interesting situation. I see version 0.6.4 mentioned as fixed in https://rubysec.com/advisories/CVE-2015-1828/ and https://github.com/rubysec/ruby-advisory-db/blob/master/gems/http/CVE-2015-1828.yml, but 0.6.4 isn't mentioned at all in the original vendor disclosure (https://groups.google.com/g/httprb/c/jkb4oxwZjkU) or in ruby/openssl#8. How did you determine that 0.6.4 contains a patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
The current advisory is incomplete and partly inaccurate in three ways.
Affected range is too broad/inaccurate
GitHub currently lists the affected versions as
< 0.7.3, but RubySec’s published advisory and the Ruby Advisory DB both document two patched version lines:>= 0.7.3~> 0.6.4This means versions in the
0.6.xline starting at0.6.4are already fixed and should not be included in the vulnerable range. The more accurate affected range is:< 0.6.4>= 0.7.0, < 0.7.3:contentReference[oaicite:6]{index=6}Patched versions are incomplete
GitHub currently lists only
0.7.3as patched, but RubySec also lists the patched maintenance line~> 0.6.4. That backported fix should be included. :contentReference[oaicite:7]{index=7}Title / weakness should reflect the actual root cause
The issue is described by the upstream disclosure and RubySec as an HTTPS MitM vulnerability caused by failure to call
OpenSSL::SSL::SSLSocket#post_connection_checkfor hostname verification. This is more precise than the current generic “Exposure of Sensitive Information to an Unauthorized Actor” wording. :contentReference[oaicite:8]{index=8}Supporting references: