[GHSA-wwcp-26wc-3fxm] JSON-lib mishandles an unbalanced comment string#7410
[GHSA-wwcp-26wc-3fxm] JSON-lib mishandles an unbalanced comment string#7410kmoens wants to merge 1 commit intokmoens/advisory-improvement-7410from
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the GHSA advisory for JSON-lib to reflect revised scoring/metadata and to capture legacy Maven coordinates after the project’s move/rename.
Changes:
- Updated advisory metadata (
modifiedtimestamp) and adjusted severity entries (removed CVSS v3, kept CVSS v4). - Added an additional affected package entry for the legacy Maven artifact
net.sf.json-lib:json-libwith an affected range through2.4.
Comments suppressed due to low confidence (1)
advisories/github-reviewed/2024/10/GHSA-wwcp-26wc-3fxm/GHSA-wwcp-26wc-3fxm.json:15
- The PR description says “Updates … CVSS v3”, but this change removes the
CVSS_V3entry entirely rather than updating it. Either re-add/update the CVSS v3 vector/score inseverity, or update the PR description to match the intended outcome.
"severity": [
{
"type": "CVSS_V4",
"score": "CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:N/VA:L/SC:N/SI:N/SA:N"
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "CVE-2024-47855" | ||
| ], | ||
| "summary": "JSON-lib mishandles an unbalanced comment string", | ||
| "details": "util/JSONTokener.java in JSON-lib before 3.1.0 mishandles an unbalanced comment string.", |
There was a problem hiding this comment.
The details text states “before 3.1.0”, but this PR also adds a separate affected coordinate capped at last_affected: 2.4 (net.sf.json-lib:json-lib). To avoid ambiguity for consumers, consider clarifying details (or adding a short note) that distinguishes the legacy Maven coordinates (affected through 2.4) from the post-move artifact line where the 3.1.0 boundary applies.
| "details": "util/JSONTokener.java in JSON-lib before 3.1.0 mishandles an unbalanced comment string.", | |
| "details": "util/JSONTokener.java in JSON-lib mishandles an unbalanced comment string. For the post-move Maven artifact org.kordamp.json:json-lib-core, versions before 3.1.0 are affected; for the legacy Maven coordinate net.sf.json-lib:json-lib, versions through 2.4 are affected.", |
Updates
Comments
The library was moved towards GitHub and changed its artifact name: