Adjust @security-severity metadata for XSS and log injection queries#21472
Open
owen-mc wants to merge 3 commits intogithub:mainfrom
Open
Adjust @security-severity metadata for XSS and log injection queries#21472owen-mc wants to merge 3 commits intogithub:mainfrom
@security-severity metadata for XSS and log injection queries#21472owen-mc wants to merge 3 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts CodeQL query metadata severities to align XSS queries with “high” severity and log injection queries with “medium” severity, and adds per-language change notes documenting the metadata updates.
Changes:
- Increase
@security-severityfrom6.1→7.8for multiple XSS-related queries (Swift, Rust, Ruby, Python, Java, Go, C++). - Decrease
@security-severityfrom7.8→6.1for log injection queries (Ruby, Python, Java, Go). - Add change-note entries under
category: queryMetadatafor each affected language.
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| swift/ql/src/queries/Security/CWE-079/UnsafeWebViewFetch.ql | Raises XSS-related query severity to 7.8. |
| swift/ql/src/change-notes/2026-03-13-adjust-xss-and-log-injection-severity.md | Documents Swift metadata change. |
| rust/ql/src/queries/security/CWE-079/XSS.ql | Raises XSS query severity to 7.8. |
| rust/ql/src/change-notes/2026-03-13-adjust-xss-and-log-injection-severity.md | Documents Rust metadata change. |
| ruby/ql/src/queries/security/cwe-117/LogInjection.ql | Lowers log injection severity to 6.1. |
| ruby/ql/src/queries/security/cwe-079/UnsafeHtmlConstruction.ql | Raises XSS-related query severity to 7.8. |
| ruby/ql/src/queries/security/cwe-079/StoredXSS.ql | Raises XSS query severity to 7.8. |
| ruby/ql/src/queries/security/cwe-079/ReflectedXSS.ql | Raises XSS query severity to 7.8. |
| ruby/ql/src/change-notes/2026-03-13-adjust-xss-and-log-injection-severity.md | Documents Ruby metadata changes. |
| python/ql/src/Security/CWE-117/LogInjection.ql | Lowers log injection severity to 6.1. |
| python/ql/src/Security/CWE-079/ReflectedXss.ql | Raises XSS query severity to 7.8. |
| python/ql/src/Security/CWE-079/Jinja2WithoutEscaping.ql | Raises XSS-related query severity to 7.8. |
| python/ql/src/change-notes/2026-03-13-adjust-xss-and-log-injection-severity.md | Documents Python metadata changes. |
| java/ql/src/Security/CWE/CWE-117/LogInjection.ql | Lowers log injection severity to 6.1. |
| java/ql/src/Security/CWE/CWE-079/XSS.ql | Raises XSS query severity to 7.8. |
| java/ql/src/Security/CWE/CWE-079/AndroidWebViewSettingsEnabledJavaScript.ql | Raises Android WebView XSS-related query severity to 7.8. |
| java/ql/src/Security/CWE/CWE-079/AndroidWebViewAddJavascriptInterface.ql | Raises Android WebView XSS-related query severity to 7.8. |
| java/ql/src/change-notes/2026-03-13-adjust-xss-and-log-injection-severity.md | Documents Java metadata changes. |
| go/ql/src/Security/CWE-117/LogInjection.ql | Lowers log injection severity to 6.1. |
| go/ql/src/Security/CWE-079/StoredXss.ql | Raises stored XSS query severity to 7.8. |
| go/ql/src/Security/CWE-079/ReflectedXss.ql | Raises reflected XSS query severity to 7.8. |
| go/ql/src/Security/CWE-079/HtmlTemplateEscapingBypassXss.ql | Raises template escaping bypass XSS query severity to 7.8. |
| go/ql/src/change-notes/2026-03-13-adjust-xss-and-log-injection-severity.md | Documents Go metadata changes. |
| cpp/ql/src/Security/CWE/CWE-079/CgiXss.ql | Raises CGI XSS query severity to 7.8. |
| cpp/ql/src/change-notes/2026-03-13-adjust-xss-and-log-injection-severity.md | Documents C++ metadata change. |
| csharp/ql/src/change-notes/2026-03-13-adjust-xss-and-log-injection-severity.md | Adds C# change note entry (but no corresponding query metadata change in this PR). |
You can also share your feedback on Copilot code review. Take the survey.
csharp/ql/src/change-notes/2026-03-13-adjust-xss-and-log-injection-severity.md
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the
@security-severityof XSS queries from 6.1 (medium) to 7.8 (high) and reduce the@security-severityof log injection queries from 7.8 (high) to 6.1 (medium).This was done for javascript two years ago. Note that one javascript XSS query (
js/xss-through-dom) was excluded because it only identifies part of a vulnerability.