Fix the event subscription in dotnet #11
Merged
+37
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the way session events are handled and tested in the .NET client, focusing on improving type safety and expanding test coverage for session event subscriptions.
Session Event Handling Improvements:
SessionEventNotification.Eventproperty fromJToken?toJsonElement?for better type safety and consistency in event deserialization.OnSessionEventRPC handler to accept astring sessionIdandJsonElement? @eventinstead of aSessionEventNotificationobject, and adjusted the event parsing logic accordingly.Test Enhancements:
Should_SessionEvt_SubscribedinSessionTests.csto verify that session event subscriptions work as expected, ensuring that user, assistant, and idle events are received during a session.