feat(gooddata-sdk): [AUTO] Deprecate LLM Endpoint API and add resolveLlmProviders endpoint#1541
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(gooddata-sdk): [AUTO] Deprecate LLM Endpoint API and add resolveLlmProviders endpoint#1541yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…LlmProviders endpoint
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1541 +/- ##
==========================================
- Coverage 78.66% 78.64% -0.02%
==========================================
Files 230 231 +1
Lines 15400 15433 +33
==========================================
+ Hits 12114 12137 +23
- Misses 3286 3296 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added SDK wrapper for the new
resolveLlmProvidersendpoint. CreatedCatalogResolvedLlmProviderandCatalogResolvedLlmModelentity model classes in a new fileresolved_llm_provider.py, addedresolve_llm_providers()service method toCatalogWorkspaceService, exported both new classes fromgooddata_sdk/__init__.py, and wrote unit tests verifying the model serialization. The deprecated endpoint/model annotations in the OpenAPI diff do not require SDK changes since the SDK does not wrap the deprecatedresolveLlmEndpointsendpoint.Impact: deprecation | Services:
gooddata-afm-client,gooddata-metadata-clientFiles changed
gooddata-sdk/packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/entity_model/resolved_llm_provider.pygooddata-sdk/packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/service.pygooddata-sdk/packages/gooddata-sdk/src/gooddata_sdk/__init__.pygooddata-sdk/packages/gooddata-sdk/tests/catalog/test_resolved_llm_provider.pySource commits (gdc-nas)
a19eb19Merge pull request #21393 from hkad98/jkd/llm-endpoint-deprecationOpenAPI diff
"/api/v1/actions/ai/llmEndpoint/test": { "post": { + "deprecated": true, + "description": "Will be soon removed and replaced by testLlmProvider." "/api/v1/actions/ai/llmEndpoint/{llmEndpointId}/test": { "post": { + "deprecated": true, + "description": "Will be soon removed and replaced by testLlmProviderById." "/api/v1/actions/workspaces/{workspaceId}/ai/resolveLlmEndpoints": { "get": { + "deprecated": true, + "description": "Will be soon removed and replaced by LlmProvider-based resolution." + "/api/v1/actions/workspaces/{workspaceId}/ai/resolveLlmProviders": { + "get": { "operationId": "resolveLlmProviders", "summary": "Get Active LLM configuration for this workspace" } + }, "JsonApiLlmEndpointIn": { + "deprecated": true, "description": "Will be soon removed and replaced by LlmProvider." "JsonApiLlmEndpointOut": { "deprecated": true }, "JsonApiLlmEndpointPatch": { "deprecated": true }, + "ResolvedLlm": { "description": "The resolved LLM configuration, or null if none is configured." }, + "ResolvedLlmProvider": { "allOf": [{ "$ref": "ResolvedLlm" }, { "properties": { "id": {...}, "models": {...}, "title": {...} } }] }, + "ResolvedLlms": { "properties": { "data": { "oneOf": [{ "$ref": "ResolvedLlmEndpoint" }, { "$ref": "ResolvedLlmProvider" }] } } }Workflow run
Generated by SDK OpenAPI Sync workflow