Open
Conversation
zigzago
force-pushed
the
feat/transcription
branch
from
46b732e to
92106bc
Compare
glaforge
force-pushed
the
feat/transcription
branch
from
92106bc to
27b7e99
Compare
sherryfox
requested changes
Apr 8, 2026
Contributor
sherryfox
left a comment
sherryfox
left a comment
There was a problem hiding this comment.
Hi @zigzago,
Thank you for this contribution! Adding the transcription fields mapping seems like a great addition. The implementation looks solid, and I really appreciate the comprehensive unit tests.
I just noticed a few small nits regarding codebase style.
Could you please update it following the comments?
Other than that, LGTM and Thanks again for the PR!
| } | ||
|
|
||
| /** | ||
| * Input transcription. The transcription is independent to the model turn which means it doesn’t |
Contributor
There was a problem hiding this comment.
Please switch to a standard ASCII single quote (doesn't) to match the codebase style
| } | ||
|
|
||
| /** | ||
| * Output transcription. The transcription is independent to the model turn which means it doesn’t |
zigzago
force-pushed
the
feat/transcription
branch
from
2210ca8 to
cb9d2e3
Compare
sherryfox
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
I implemented the Python bidi demo in Kotlin. The behavior matches the Python version, except for the STT transcriptions, which are currently not exposed by the Java ADK SDK.
Solution:
Add the transcription fields to the mapping.
Testing Plan
Tested with the bidi demo. I may contribute this demo to the ADK samples project.
Unit Tests:
[WARNING] Tests run: 1093, Failures: 0, Errors: 0, Skipped: 10Manual End-to-End (E2E) Tests:
Tested using the bidi demo
Checklist