Skip to content

Conversation

@alexcheng1982
Copy link

In the current implementation of Spring AI integration, tool calls are handled by Spring AI, this means the code needs to handle the conversion between Spring AI tools and ADK tools. This is unnecessary and introduces serval issues, like ToolContext is null (see #699 ), before and after tool callbacks are not invoked.

In this PR, tool calls are handled by ADK, just like other BaseLlm implementations.

  • Spring AI tool calls execution is disabled by setting internalToolExecutionEnabled to false in ToolCallingChatOptions.
  • FunctionToolCallback in Spring AI simply returns empty strings. FunctionToolCallback is only used to pass tool definitions. The actual tool calls are handled by ADK.
  • Handles ToolResponseMessage in MessageConverter.
  • Removed unused code and test.

Let ADK call tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant