Tool call fix for Spring AI - Let ADK call tools #733
+30
−215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation of Spring AI integration, tool calls are handled by Spring AI, this means the code needs to handle the conversion between Spring AI tools and ADK tools. This is unnecessary and introduces serval issues, like
ToolContextisnull(see #699 ), before and after tool callbacks are not invoked.In this PR, tool calls are handled by ADK, just like other
BaseLlmimplementations.internalToolExecutionEnabledtofalseinToolCallingChatOptions.FunctionToolCallbackin Spring AI simply returns empty strings.FunctionToolCallbackis only used to pass tool definitions. The actual tool calls are handled by ADK.ToolResponseMessageinMessageConverter.