feat: Improving LoggingPlugin #760
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Improving LoggingPlugin
This CL refactors and improves the
LoggingPluginin the ADK core.Here's a summary of the changes:
Consistent Agent Name Logging: The plugin now consistently retrieves the agent name from
callbackContext.agentName()inbeforeAgentCallbackandafterAgentCallback, instead of usingagent.name().Enhanced LLM Response Logging: The
formatContentmethod has been significantly updated to provide more detailed logging for different types ofContent.parts()within an LLM response. It now explicitly logs:functionCallandfunctionResponse.codeExecutionResultand other part types.The different parts are joined by " | ".
Improved Optional Field Logging: Optional fields like
llmResponse.errorMessage()andtoolContext.functionCallId()are now always logged, displaying "None" when the optional is empty, rather than only logging when the value is present.Simplified Argument Formatting: The
formatArgsmethod now usesargs.toString()for formatting, simplifying the code while still handling truncation for long argument strings.Removed Redundant Error Logging: Duplicate
logger.errorcalls withinonLlmErrorandonToolErrorhave been removed, as the precedinglogcalls already capture the necessary error information.Test Updates:
LoggingPluginTest.javahas been updated to mockmockCallbackContext.invocationContext()and remove an unnecessary mock formockCallbackContext.branch().