Extend TimeUnitMismatch to check return statements.#5581
Merged
copybara-service[bot] merged 1 commit intomasterfrom Mar 9, 2026
Merged
Extend TimeUnitMismatch to check return statements.#5581copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
I also added a test for method references, which doesn't yet work. We should handle these, but boy are they annoying at times. PiperOrigin-RevId: 881033725
copybara-service
bot
force-pushed
the
test_879609439
branch
from
4baadb8 to
8c1a6bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend TimeUnitMismatch to check return statements.
I also added a test for method references, which doesn't yet work. We should handle these, but boy are they annoying at times.