Add throws clauses when necessary when hoisting exceptions.#5582
Merged
copybara-service[bot] merged 1 commit intomasterfrom Mar 10, 2026
Merged
Add throws clauses when necessary when hoisting exceptions.#5582copybara-service[bot] merged 1 commit intomasterfrom
throws clauses when necessary when hoisting exceptions.#5582copybara-service[bot] merged 1 commit intomasterfrom
Conversation
I made this just add Exception/Throwable to the enclosing method, given Java Practices encourages that for tests. This is of course assuming the enclosing method is directly a test method, which is an assumption! PiperOrigin-RevId: 881439895
647951c to
d06d1d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
throwsclauses when necessary when hoisting exceptions.I made this just add Exception/Throwable to the enclosing method, given Java Practices encourages that for tests. This is of course assuming the enclosing method is directly a test method, which is an assumption!