chor(storage): Restart & delete resumable upload part 2#23376
chor(storage): Restart & delete resumable upload part 2#23376dazuma merged 5 commits intogoogleapis:mainfrom
Conversation
bajajneha27
left a comment
There was a problem hiding this comment.
Shouldn't we have to update the tests accordingly?
updating the test case is not required since we are setting the value of command.delete_upload here |
I can see one place for sure https://github.com/googleapis/google-api-ruby-client/pull/21896/files#diff-760f5664ec67b31a778b73e99c7976822f091ef3ad45eb654a3704c72fb7f555R299 |
missed it as this was not affecting the test outcome updated it now |
|
@dazuma I'm not sure about the new check multi-approver. I'm not able to merge the PR with just my approval. |
Feature to support Restart and Delete resumable upload functionality
storage library Implementation linked with- googleapis/google-cloud-ruby#29215
Core library Implementation(merged): #21896