[DRAFT] fix: remove deprecated rsa dependency

[daniel-sanche]

Blocked on #1929

After that PR is merged and released, this follow-up will remove rsa as a required dependency.

We want to give users a chance to see the warning before making this change though

[gemini-code-assist]

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a preparatory step towards fully deprecating the rsa library as a core dependency. It refactors the RSA verification and signing mechanisms to conditionally load the rsa module only when its specific key formats are utilized. This change aims to reduce the default dependency footprint for users who primarily use cryptography for RSA operations, while maintaining backward compatibility for those still using rsa-specific key types. The PR is currently a draft, awaiting the merge and release of a prerequisite change.

Highlights

• Dependency Removal: The rsa library has been removed as a direct, required installation dependency, making it optional for users who do not explicitly rely on its specific key types.
• Lazy Loading Implementation: The _python_rsa module, which provides rsa library functionality, is now lazily loaded within RSAVerifier and RSASigner classes. It will only be imported if rsa.key.PublicKey or rsa.key.PrivateKey types are encountered, reducing the initial import overhead.
• Error Handling Updates: Docstrings for RSAVerifier and RSASigner have been updated to explicitly mention that an ImportError may be raised if rsa.key.PublicKey or rsa.key.PrivateKey are used without the rsa library being installed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes rsa as a required dependency by making its usage optional. The changes involve moving the rsa dependency from the main list to the testing extras in setup.py and using lazy imports for the _python_rsa module. This ensures that an ImportError is raised only when rsa-based keys are used without the library being installed. The docstrings have also been updated to reflect this change. I've found one minor issue in a docstring that appears to be a copy-paste error.

[gemini-code-assist]

There seems to be a copy-paste error in this docstring. The RSASigner class operates on a private_key, but the Raises section refers to rsa.key.PublicKey. This should be corrected to rsa.key.PrivateKey for accuracy.

Suggested change

	ImportError: if called with an rsa.key.PublicKey, when the rsa library is not installed
	ImportError: if called with an rsa.key.PrivateKey, when the rsa library is not installed