impl(oauth2): add RegionalAccessBoundary Credentials decorator#16081
impl(oauth2): add RegionalAccessBoundary Credentials decorator#16081scotthart merged 1 commit intogoogleapis:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the RegionalAccessBoundaryTokenManager to manage and cache routing tokens for Regional Access Boundaries (RAB) across several credential types, including Service Account and External Account credentials. The Credentials interface is refactored to support AllowedLocationsRequest, and the decoration logic is updated to integrate the new manager, controlled by a new testing macro. Feedback highlights the need to maintain C++14 compatibility by replacing C++17 features—such as std::variant, std::scoped_lock, and std::holds_alternative—with absl or standard C++14 alternatives. Furthermore, the retry logic should be expanded to include kDeadlineExceeded, and the AllowedLocations endpoint should be accessed using GET requests.
35c6140 to
b770286
Compare
b770286 to
6eea841
Compare
6eea841 to
560204d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16081 +/- ##
==========================================
+ Coverage 92.66% 92.70% +0.03%
==========================================
Files 2348 2351 +3
Lines 217564 217954 +390
==========================================
+ Hits 201612 202052 +440
+ Misses 15952 15902 -50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
560204d to
14dad9f
Compare
14dad9f to
beeac5a
Compare
No description provided.