chore(Datastore): Add Operation and Attempt metrics for HttpJson transport#12086
Merged
chore(Datastore): Add Operation and Attempt metrics for HttpJson transport#12086
Conversation
jinseopkim0
reviewed
Mar 17, 2026
Comment on lines
+118
to
+123
| String status = StatusCode.Code.OK.toString(); | ||
| try { | ||
| return callable.call(); | ||
| } catch (Exception e) { | ||
| status = DatastoreException.extractStatusCode(e); | ||
| throw e; |
Contributor
There was a problem hiding this comment.
If we get an Error that's not caught, then the status would remain as OK, right? Would it make sense to set the OK status later? e.g.
String status = StatusCode.Code.UNKNOWN.toString();
try {
T result = callable.call();
status = StatusCode.Code.OK.toString();
return result;
} catch (Exception e) {
// ...
Member
Author
There was a problem hiding this comment.
Oh I see what you're saying. Ok, let me update that
jinseopkim0
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds operation and attempt metrics that are being recorded via Gax. Since gRPC can integrate natively with Gax, this metrics are captured. This instruments the metrics to be collected via HttpJson.
Sample view of the metrics collected:
