Skip to content

chore: consolidate prettierignore and prettierrc files: handwritten #8081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feywind wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: consolidate prettierignore and prettierrc files: handwritten #8081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"arrify": "^2.0.0",
"duplexify": "^4.1.3",
"extend": "^3.0.2",
"google-auth-library": "^10.0.0-rc.1",
"google-auth-library": "^10.6.2",
"html-entities": "^2.5.2",
"retry-request": "^8.0.0",
"teeny-request": "^10.0.0"
Expand Down
4 changes: 2 additions & 2 deletions core/packages/gaxios/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
},
"repository": {
"type": "git",
"directory": "packages/gaxios",
"url": "https://github.com/googleapis/google-cloud-node-core.git"
"directory": "core/packages/gaxios",
"url": "https://github.com/googleapis/google-cloud-node.git"
},
"keywords": [
"google"
Expand Down
1 change: 1 addition & 0 deletions core/packages/logging-utils/samples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
},
"devDependencies": {
"@google-cloud/typeless-sample-bot": "^2.1.0",
"@types/node": "^25.6.0",
Comment thread
feywind marked this conversation as resolved.
"gts": "^5.0.0",
"mocha": "^10.0.0"
}
Expand Down
6 changes: 3 additions & 3 deletions core/packages/logging-utils/samples/system-test/test.quickstart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
* limitations under the License.
*/

import * as path from 'path';
import * as assert from 'assert';
import path from 'path';
import assert from 'assert';
import {describe, it} from 'mocha';
import * as cp from 'child_process';
import cp from 'child_process';

const cwd = path.join(__dirname, '../..');

Expand Down
4 changes: 3 additions & 1 deletion core/packages/logging-utils/samples/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
"es2018",
"dom"
],
"moduleResolution": "node"
"types": [
"node"
]
Comment thread
feywind marked this conversation as resolved.
},
"include": [
"system-test/*.ts"
Expand Down
9 changes: 6 additions & 3 deletions handwritten/logging-bunyan/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@
},
"dependencies": {
"@google-cloud/logging": "^11.0.0",
"google-auth-library": "^9.0.0"
"google-auth-library": "^10.6.2"
},
"devDependencies": {
"@google-cloud/common": "^5.0.0",
"@google-cloud/common": "^6.0.0",
"@types/bunyan": "^1.8.4",
"@types/express": "^4.16.0",
"@types/mocha": "^9.0.0",
Expand All @@ -72,7 +72,7 @@
"cpy-cli": "^4.0.0",
"delay": "^5.0.0",
"express": "^4.16.3",
"gts": "^5.0.0",
"gts": "^7.0.0",
"jsdoc": "^4.0.0",
"jsdoc-fresh": "^3.0.0",
"jsdoc-region-tag": "^3.0.0",
Expand All @@ -86,5 +86,8 @@
"peerDependencies": {
"bunyan": "*"
},
"overrides": {
"whatwg-url": "^14.0.0"
},
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/logging-bunyan"
}
4 changes: 2 additions & 2 deletions handwritten/logging/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"postpublish": "./.kokoro/publish-min.sh"
},
"dependencies": {
"@google-cloud/common": "^5.0.0",
"@google-cloud/common": "^6.0.0",
"@google-cloud/paginator": "^5.0.0",
"@google-cloud/projectify": "^4.0.0",
"@google-cloud/promisify": "4.0.0",
Expand All @@ -60,7 +60,7 @@
"eventid": "^2.0.0",
"extend": "^3.0.2",
"gcp-metadata": "^6.0.0",
"google-auth-library": "^9.0.0",
"google-auth-library": "^10.6.2",
"google-gax": "^4.0.3",
"long": "^5.3.2",
"on-finished": "^2.3.0",
Expand Down
1 change: 1 addition & 0 deletions handwritten/pubsub/.eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
**/node_modules
**/.coverage
bin/
build/
docs/
protos/
Expand Down
4 changes: 2 additions & 2 deletions handwritten/pubsub/bin/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# benchwrapper

benchwrapper is a lightweight gRPC server that wraps the pubsub library for
bencharmking purposes.
benchmarking purposes.

## Running

```
cd nodejs-pubsub
cd handwritten/pubsub
npm install
export PUBSUB_EMULATOR_HOST=localhost:8080
npm run benchwrapper -- --port 50051
Expand Down
8 changes: 8 additions & 0 deletions handwritten/pubsub/test/publisher/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,10 @@ describe('Publisher', () => {
it('should call through to publishMessage', () => {
const stub = sandbox.stub(publisher, 'publishMessage');

// This warning is not real, but it should be resolved by future work
// on the linting config.
//
// eslint-disable-next-line @typescript-eslint/no-floating-promises
publisher.publish(buffer, spy);

const [{data}, callback] = stub.lastCall.args;
Expand All @@ -177,6 +181,10 @@ describe('Publisher', () => {
const stub = sandbox.stub(publisher, 'publishMessage');
const attrs = {};

// This warning is not real, but it should be resolved by future work
// on the linting config.
//
// eslint-disable-next-line @typescript-eslint/no-floating-promises
publisher.publish(buffer, attrs, spy);

const [{attributes}, callback] = stub.lastCall.args;
Expand Down
Loading
Loading