fix: Handle null server address

[blakeli0]

In case of an invalid endpoint such as localhost:-1, the current parsing logic returns null for server address. This PR made server address nullable. And added a null check for the port parsing.

In addition, added a try catch for the whole parsing logic because serviceAddress and serverPort should only be used for obersevability and should not affect regular requests.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the EndpointContext class by handling cases where the server address is null or invalid. This prevents potential exceptions and ensures that observability features do not negatively impact core client functionality. The changes include additional null checks, exception handling, and updated test cases.

Highlights

• Null Server Address Handling: The pull request addresses a potential null pointer exception when parsing the server address from the endpoint. It adds a null check for hostAndPort and wraps the server address and port parsing logic in a try-catch block.
• Observability Improvement: The changes ensure that errors during server address and port parsing do not affect the main client requests, as these values are only used for observability purposes.
• Test Case Update: The pull request includes an updated test case and a new test case to validate the handling of invalid endpoints and ports.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where a null server address could cause problems by adding exception handling around server address and port parsing. The changes are logical and include a new test case to cover the fix. My feedback focuses on refining the exception handling to be more specific, which improves the robustness of the code by not suppressing critical system errors.

[sonarqubecloud]

Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate failed for 'java_showcase_integration_tests'

Failed conditions
57.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[blakeli0]

Closing in favor of googleapis/google-cloud-java#12184