Open
Conversation
|
Results for build job (at 6f16cf5): +webgpu:api,operation,command_buffer,programmable,immediate:basic_execution:* - 51 cases, 51 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:update_data:* - 3 cases, 3 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:pipeline_switch:* - 4 cases, 4 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:use_max_immediate_size:* - 3 cases, 3 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:typed_array_arguments:* - 36 cases, 36 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:multiple_updates_before_draw_or_dispatch:* - 3 cases, 3 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:render_pass_and_bundle_mix:* - 1 cases, 1 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:render_bundle_isolation:* - 1 cases, 1 subcases (~1/case)
-TOTAL: 280581 cases, 2321554 subcases
+TOTAL: 280683 cases, 2321656 subcases |
shaoboyan091
force-pushed
the
immediate-operation
branch
from
834cd4a to
509b754
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts
Outdated
Show resolved
Hide resolved
shaoboyan091
force-pushed
the
immediate-operation
branch
2 times, most recently
from
2c527ae to
ffe4c7c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shaoboyan091
force-pushed
the
immediate-operation
branch
2 times, most recently
from
4c8a817 to
7e4e8d8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts
Outdated
Show resolved
Hide resolved
shaoboyan091
force-pushed
the
immediate-operation
branch
from
7e4e8d8 to
2e3521f
Compare
Implement operation tests for setImmediates in ComputePassEncoder, RenderPassEncoder, and RenderBundleEncoder. - Add basic execution tests for scalar, vector, and struct types. - Add tests for partial updates and multiple updates (using range verification). - Add tests for pipeline switching (no inheritance). - Add tests for large data (maxImmediateSize) with range verification. - Add tests for TypedArray arguments with offsets. - Add tests for mixing render pass and bundle execution.
shaoboyan091
force-pushed
the
immediate-operation
branch
from
2e3521f to
6f16cf5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement operation tests for setImmediates in ComputePassEncoder, RenderPassEncoder, and RenderBundleEncoder.
Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.