Skip to content

Add mixed swizzle and indexing tests#4570

Merged
sudonatalie merged 1 commit intogpuweb:mainfrom
sudonatalie:swizzle-oob
Jan 22, 2026
Merged

Add mixed swizzle and indexing tests#4570
sudonatalie merged 1 commit intogpuweb:mainfrom
sudonatalie:swizzle-oob

Conversation

@sudonatalie
Copy link
Contributor

Check that a valid mix of swizzles and index works and that an invalid OOB case fails.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@sudonatalie sudonatalie requested a review from jrprice January 20, 2026 20:09
@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Results for build job (at 93b8515):

-webgpu:shader,validation,expression,access,vector:concrete:* - 60 cases, 6480 subcases (~108/case)
-webgpu:shader,validation,expression,access,vector:abstract:* - 24 cases, 2592 subcases (~108/case)
+webgpu:shader,validation,expression,access,vector:concrete:* - 60 cases, 6600 subcases (~110/case)
+webgpu:shader,validation,expression,access,vector:abstract:* - 24 cases, 2640 subcases (~110/case)
-TOTAL: 285746 cases, 2344470 subcases
+TOTAL: 285746 cases, 2344638 subcases

@sudonatalie sudonatalie force-pushed the swizzle-oob branch 2 times, most recently from f3c5cc1 to 5aa0dd7 Compare January 20, 2026 21:55
Check that a valid mix of swizzles and index works and that an invalid OOB case fails.
@sudonatalie sudonatalie merged commit 68544fd into gpuweb:main Jan 22, 2026
1 check passed
@sudonatalie sudonatalie deleted the swizzle-oob branch January 22, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants