core: Restart store on revert errors to clear poisoned writer#6422
Merged
incrypto32 merged 1 commit intomasterfrom Mar 9, 2026
Merged
core: Restart store on revert errors to clear poisoned writer#6422incrypto32 merged 1 commit intomasterfrom
incrypto32 merged 1 commit intomasterfrom
Conversation
lutter
approved these changes
Mar 6, 2026
| /// New dynamic data source was created that requires filter updates. | ||
| DynamicDataSourceCreated, | ||
| /// A data source reached its end block. | ||
| DataSourceExpired, |
Collaborator
There was a problem hiding this comment.
I assume this is unused since we already have to handle the end block of data sources by just ignoring any matching triggers.
The runner FSM refactor mapped Action::Restart from handle_revert to RestartReason::DataSourceExpired, skipping store.restart(). Fix by using RestartReason::StoreError for revert errors and remove the unused DataSourceExpired variant.
incrypto32
force-pushed
the
krishna/fix-runner-revert-store-restart
branch
from
a60d360 to
a0073b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6298 mapped
Action::Restartfromhandle_reverttoRestartReason::DataSourceExpired, which skipsstore.restart(). This meant a poisoned writer from a revert error would never be cleared, causing the subgraph to loop indefinitely until process restart.RestartReason::StoreErrorfor revert errors sostore.restart()is always called (it's a no-op when not poisoned)DataSourceExpiredvariant fromRestartReason