Added manifest entry to the eventbus-java jar file#702
Open
plumstone wants to merge 1 commit intogreenrobot:masterfrom
Open
Added manifest entry to the eventbus-java jar file#702plumstone wants to merge 1 commit intogreenrobot:masterfrom
plumstone wants to merge 1 commit intogreenrobot:masterfrom
Conversation
Collaborator
|
Thanks! We'll have a look at some point if that is enough (note: I remember something about package names not being allowed to overlap, need to check if the Android artifact ever is supposed to use modules, too). |
Author
|
The build failed due to an error in the jdk setup process. Maybe we should consider updating the jdk to temurin (successor of adopt) https://github.com/actions/setup-java#basic |
Collaborator
|
@plumstone Thanks for the info! Fixed in |
plumstone
force-pushed
the
507-java-9-modular-support-request
branch
from
7d6bbe4 to
73f15d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves the warning mentioned in #507