Show native subtitles when the video is fullscreen#15734
Open
Show native subtitles when the video is fullscreen#15734
Conversation
abeddow91
commented
Apr 21, 2026
Comment on lines
50
to
52
| } | ||
| `; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
These have been removed for now as they're not being used and the fullscreen version should use native design for now.
abeddow91
force-pushed
the
ab/show-fullscreen-subtitles
branch
from
ee9d903 to
6cae7d9
Compare
github-actions
Bot
removed
the
run_chromatic
abeddow91
force-pushed
the
ab/show-fullscreen-subtitles
branch
from
6cae7d9 to
a977b21
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
added
run_chromatic
github-actions
Bot
removed
the
run_chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds css rules to control the visibility of native subtitles when a video is fullscreen.
NB the positioning of cues in handleLoadedMetadata is currently causing cues to crash into progress bar in fullscreen. This will be addressed in a future PR.
Why?
When a video is played inline, DCR prefers custom subtitle overlay and so hides the native subtitles with CSS.
With the introduction of default (or long form) self hosted videos, there is a requirement to support the video player in fullscreen. Up until now, no self hosted video types support fullscreen. In order to fulfill this requirement, we will be serving the native browser fullscreen implementation as a first pass, rather than a custom overlay.
Screenshots