Refactor ControlsPosition in self-hosted video #15738
Merged
Conversation
domlander
added
run_chromatic
github-actions
Bot
removed
the
run_chromatic
abeddow91
approved these changes
Apr 22, 2026
SHession
reviewed
Apr 22, 2026
| * The position of subtitles and the audio icon. | ||
| */ | ||
| controlsPosition?: 'top' | 'bottom'; | ||
| controlsPosition?: ControlsPosition; |
Contributor
There was a problem hiding this comment.
Should this type and prop also be renamed?
Contributor
Author
There was a problem hiding this comment.
I think consumers of this component should still refer to the position of the controls. The position of the subtitles is derived from the position of the controls passed in here.
|
Seen on PROD (merged by @domlander 9 minutes and 55 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
No-op change (except one story).
Renamed
controlsPositiontoiconsPositionin<SelfHostedVideoPlayer />. Since this prop refers only to the position of the icons, the renaming makes it clearer that the position of the progress bar is unaffected. The progress bar would not have been thought of as a control, but now might be following #15726.Removes duplicated exports in
SelfHostedVideoPlayerIcons. These were unintentionally included during a refactor here.Inverts a bool for a story.
Why?
Consumers of
<SelfHostedVideo />still only need to specify the condition of the controls. The player component<SelfHostedVideoPlayer />receives bothiconsPositionandsubtitlesPositionas these can differ.