Open
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Rather than adding flex.acast.com prefix, frontend should provide ad urls for audio elements and audio atoms
davidfurey
force-pushed
the
df/podcast-ads-refactor
branch
from
7c6cc48 to
f40d1a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Rather than adding the https://flex.acast.com prefix to audio files in DCR, frontend will provide ad and ad-free urls for audio elements and audio atoms.
Why?
We are pushing the generation of the URLs of audio assets containing ads to Concierge. This is because the logic is about to get more complicated. We'd like to centralise it before we make changes.