Conversation
jiawen
force-pushed
the
jiawen-hl_main
branch
from
62a5895 to
9bae1f1
Compare
|
Any suggestions on how / where to put tests? A simple test would be to use something like |
| if (result != 0) { | ||
| // Some paths in generate_filter_main() will fail with user_error or similar (which throws an exception | ||
| // due to how libHalide is built for Python), but some paths just return an error code. For consistency, | ||
| // handle both by throwing a C++ exception, which pybind11 turns into a Python exception. |
There was a problem hiding this comment.
I updated this comment to be more clear.
There was a problem hiding this comment.
Sorry to be a noodge, but now that this hasn't been substantially changed, can we keep it inline? It will make the diff clearer.
|
Hold off on merging - it occurs to me that one can implement |
|
@alexreinking PTAL. Much cleaner I think. |
alexreinking
left a comment
alexreinking
left a comment
There was a problem hiding this comment.
Looks good with one nitpick
| if (result != 0) { | ||
| // Some paths in generate_filter_main() will fail with user_error or similar (which throws an exception | ||
| // due to how libHalide is built for Python), but some paths just return an error code. For consistency, | ||
| // handle both by throwing a C++ exception, which pybind11 turns into a Python exception. |
There was a problem hiding this comment.
Sorry to be a noodge, but now that this hasn't been substantially changed, can we keep it inline? It will make the diff clearer.
2 participants
No description provided.