Replace calls to system() with new run_process() helper. #8940
+47
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreinking
requested review from
abadams,
derek-gerstmann,
shoaibkamil and
slomp
shoaibkamil
reviewed
Feb 9, 2026
shoaibkamil
approved these changes
Feb 9, 2026
Contributor
shoaibkamil
left a comment
shoaibkamil
left a comment
There was a problem hiding this comment.
I'm surprised we only used system() in so few cases. Good idea to use something safer.
mcourteaux
requested changes
Feb 11, 2026
mcourteaux
approved these changes
Feb 11, 2026
Contributor
mcourteaux
left a comment
mcourteaux
left a comment
There was a problem hiding this comment.
LGTM. Thanks for clarifications! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
system()is just one of those functions that makes me shiver. I noticed it while working on #8939Replace all uses of system() with a new run_process() helper that consults the
PATH, but doesn't shell out.