Prevent Timeline selections that are out of bounds#147
Open
TuongNM wants to merge 1 commit intohaskell:masterfrom
Open
Prevent Timeline selections that are out of bounds#147TuongNM wants to merge 1 commit intohaskell:masterfrom
TuongNM wants to merge 1 commit intohaskell:masterfrom
Conversation
timelineSetSelection now returns Nothing in case of an invalid selection that's solely outside of the TimelineView for both a PointSelection and a RangeSelection. A RangeSelection is additionally clamped to the bounds of the TimelineView to stop dragging when the bounds have been reached. The new return value is processed inside the Mouse and Event handling accordingly. Within this the EventCursorChangedIndex handling now includes updating previously omitted views. This fixes an issue where following a RangeSelection with a selection inside the EventsView would cause the previously omitted views to still display the information of the RangeSelection and not the equivalent PointSelection of the EventsView selection. Lastly, fix an issue from the previous commit that added styling usage inside the EventsView. The wrong background color was applied to a selected Event when making the second PointSelection after a RangeSelection or a PointSelection without a preceding RangeSelection. StateSelected is now always applied when selected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40
While testing this I noticed an issue for #145 where a wrong background color was used when making a
PointSelection. I included a fix for that in this PR.