Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,26 @@ lint-fix: ## Execute linting and fix
-e FIX_MARKDOWN_PRETTIER=true \
-e FIX_NATURAL_LANGUAGE=true)

npm-audit-fix: ## Execute npm audit fix
@set -uo pipefail; \
overall_status=0; \
packages="$$(find actions -type f -name package.json -not -path '*/node_modules/*' -print | sort)"; \
echo "Running npm audit fix for package.json files under actions/ ..."; \
for pkg in $$packages; do \
pkg_dir="$$(dirname "$$pkg")"; \
echo "---"; \
npm install --prefix "$$pkg_dir"; \
echo "npm audit fix in $$pkg_dir"; \
if ! npm --prefix "$$pkg_dir" audit fix; then \
overall_status=1; \
fi; \
done; \
exit $$overall_status

ci: ## Execute CI tasks
$(MAKE) npm-audit-fix
$(MAKE) lint

test-build-application: ## Build the test application image
@docker buildx build \
--push --platform linux/amd64,linux/arm64 \
Expand Down
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,12 @@ actions/{category}/{action-name}/
#### Linting & Testing

```bash
make ci # Run all CI checks

# Linting helpers
make lint # Run the dockerized Super Linter
make lint-fix # Attempt auto-fixes for lint findings
make npm-audit-fix # Fix npm audit issues in action packages

# Container & Helm validation helpers
make test-build-application # Build and push the sample test application image
Expand Down
2 changes: 1 addition & 1 deletion actions/helm/generate-docs/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ runs:
- if: ${{ steps.prepare-variables.outputs.values-file }}
uses: losisin/helm-values-schema-json-action@f3517c55537e26953c8a11be7549ea908990130d # v2.3.2
with:
input: ${{ steps.prepare-variables.outputs.values-file }}
values: ${{ steps.prepare-variables.outputs.values-file }}
working-directory: ${{ steps.prepare-variables.outputs.working-directory }}

- name: Setup Node.js
Expand Down
5 changes: 5 additions & 0 deletions actions/helm/generate-docs/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions actions/helm/generate-docs/package.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"name": "generate-docs",
"dependencies": {
"@textlint/textlint-plugin-markdown": "^15.5.0",
"markdownlint-cli2": "^0.20.0",
Expand Down
10 changes: 6 additions & 4 deletions actions/helm/release-chart/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -187,13 +187,15 @@ runs:
cmd: |
${{ steps.chart-values-updates.outputs.yq-command }}

- uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0

- shell: bash
run: npm install yaml
- name: Setup Node.js
uses: hoverkraft-tech/ci-github-nodejs/actions/setup-node@c9d9d041ba4ef35695ee469c4782fa6a8bbebbcc # 0.21.2
with:
working-directory: ${{ github.action_path }}

- name: Rewrite the Chart.lock to match with updated ombrella dependencies if any
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
env:
NODE_PATH: ${{ github.action_path }}/node_modules
with:
script: |
const fs = require('node:fs');
Expand Down
28 changes: 28 additions & 0 deletions actions/helm/release-chart/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions actions/helm/release-chart/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"name": "release-chart",
"dependencies": {
"yaml": "^2.8.2"
}
}
Loading