Pin pytest to a version that doesn't require six#372
Closed
willkg wants to merge 1 commit intohtml5lib:masterfrom
willkg:fix-pytest
Closed
Pin pytest to a version that doesn't require six#372willkg wants to merge 1 commit intohtml5lib:masterfrom willkg:fix-pytest
willkg wants to merge 1 commit intohtml5lib:masterfrom
willkg:fix-pytest
Conversation
Contributor
Author
|
Pretty sure this gets around the problem that prompted issue #370. Though we should do that as well at some point. @gsnedders When Travis and AppVeyor are happy, can you review this? |
Contributor
Author
|
There's another PR that fixes That's the root cause of the AppVeyor failure. |
Contributor
|
Fyi, I'll be able to help in about 15 mins.
…On Wed, 29 Nov 2017 08:02 Will Kahn-Greene ***@***.***> wrote:
There's another PR that fixes tox.ini to use requirements-test.txt. I
could pull that change into this one, but then that one will require more
work to merge. I'm inclined to leave this as is and let that one fix
tox.ini.
That's the root cause of the AppVeyor failure.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#372 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA69PhwjMbOvoXKFnMvxVuwd3sYjsMRks5s7K0LgaJpZM4QuOx6>
.
|
Contributor
|
I've rebased & fixed my PR (#364), and if you rebase this PR on top of mine, I think everything should be green. |
Merged
Contributor
Author
|
PR #364 pins pytest now. I'm going to close this PR out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest 3.3.0 added
six>=1.10.0as a requirement which messes us up. Either we should drop support for six 1.9 or we can land this which pins pytest to a slightly earlier version as a stopgap.