Merged
Conversation
This also implements `Header for T` and provides generic conversions between `Header` and `HeaderName` / `HeaderValue`
Member
Author
|
Don't think much here should be controversial -- this is mostly just a big cleanup. Going to go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precursor to #335, follow-up to #315. This removes all the manual
name,value, andapplymethods defined on the typed headers in favor of theHeadertrait. This also adds conversions to easily go from&impl Header->HeaderName/HeaderValue, which allows for more convenient use. Which also enabled us to remove a fair amount of code from the manualIntoHeaderValuesimplementations on various typed headers.Example
before
after
Future directions
This doesn't preclude changing
Header::insert_headerto take oneHeaderargument rather than two separate ones. But at least under the current API it significantly simplifies usage patterns and removes lots of duplicates.