[Type Check] for Qwen-Image-Edit and Wan #12985
Open
+19
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Issues:
In
Qwen-Image-Edit-Pluspipeline, if there is no image input, the variablescondition_image_sizes,condition_images,vae_image_sizesandvae_imagesare not assigned but used. And thecheck_inputmethod does not really make sureimageis notNoneeither.In
Wanseries related pipeline, the actually usedschedulerisUniPCMultistepSchedulerrather thanFlowMatchEulerDiscreteScheduler, which is correct in docstring but with wrong type hint. It is confusing for readers.Fixes:
Assign relevant variables with initial value
Noneand it also makes it possible forQwen-Image-Edit-Pluspipeline to betext-to-imagecompatible in the future.For Wan, just fix the type hints.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.