Conversation
danieldk
force-pushed
the
flake-ci-test
branch
from
2204c2f to
315bfad
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Running this output will run the kernel's tests. CI tests must be marked with `kernels_ci`. This avoids running all tests, which may be too expensive for CI.
danieldk
force-pushed
the
flake-ci-test
branch
from
315bfad to
bc0aaba
Compare
`rec` can lead to annoying issues due to shadowing, as was happening here with the `kernels` output.
MekkCyber
left a comment
MekkCyber
left a comment
There was a problem hiding this comment.
Awesome! I like the marker idea
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks!
Do we want to propagate this marker to the tests we maintain in kernels-community?
|
|
||
| ## Kernel tests | ||
|
|
||
| Kernel tests are stored in the `tests` directory. Since running all |
There was a problem hiding this comment.
Should we add guidance on what kind of tests would be ideal for this? Like we would want tests that run fast yet provide some confidence?
| $ nix run .#ci-test | ||
| ``` | ||
|
|
||
| On non-NixOS systems, make sure that |
There was a problem hiding this comment.
So, currently, it seems limited to CUDA-only tests?
There was a problem hiding this comment.
It also works on non-CUDA, I should update the doc to mention this. Basically it is like this:
- If the kernels supports one of CUDA/ROCm/XPU/Metal, the test for the supported backend will be run.
- If the kernels supports multiple backends, CUDA is the default on Linux and Metal on macOS.
- You can always run the tests for any variant with
nix run .#ciTests.<variant>, for instance:nix run .#ciTests.torch210-cxx11-cpu-x86_64-linux
There was a problem hiding this comment.
Thanks for explaining. Should we include this more explicitly in the docs then?
4 participants
Running this output will run the kernel's tests. CI tests must be marked with
kernels_ci. This avoids running all tests, which may be too expensive for CI.Example run: https://github.com/huggingface/kernels-community/actions/runs/21980763830/job/63503495972?pr=364