Claude/fix issue 1225 invocation node not in tree#1249
Merged
GrahamTheCoder merged 4 commits intoicsharpcode:masterfrom Apr 13, 2026
Merged
Conversation
…st cross-tree attributes When a parameter is defined in an external assembly or different source file, its AttributeSyntax nodes belong to a different syntax tree than the current semantic model. Calling SemanticModel.GetTypeInfo on such nodes throws "Node is not within syntax tree". Fall back to a name-based check when the attribute's syntax tree differs from the model's tree. https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
Adds a unit test in the existing ByRefTests style that verifies conversion of an external-library method call (with metadata parameter attributes) does not throw "Node is not within syntax tree". https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
…te References The previous test commit used `References` which is a `private static` member of ConverterTestBase and not accessible from the derived ByRefTests class. Replace with `DefaultReferences.With()` (equivalent references) and also add `ShowCompilationErrors = true` for consistency with other tests. https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
GrahamTheCoder
force-pushed
the
claude/fix-issue-1225-invocation-node-not-in-tree
branch
from
dd9c485 to
8af8bc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1225