Add regression test for issue #1091: interface DefaultMember Value access#1250
Merged
GrahamTheCoder merged 1 commit intoicsharpcode:masterfrom Apr 13, 2026
Conversation
…er Value access
When an interface or type has [DefaultMember("Value")] and VB code explicitly
accesses .Value, the converter was incorrectly stripping the member access,
producing `p` instead of `p.Value`.
The fix (already in commit 924785a) adds `&& p.Parameters.Any()` to the
`isDefaultProperty` check in ConvertMemberAccessExpressionAsync. This ensures
only truly indexed (parameterized) default properties are stripped, while
parameterless default members like Value retain their explicit access.
This commit adds a regression test covering the exact scenario from issue icsharpcode#1091:
an interface with <DefaultMember("Value")> where VB code explicitly reads and
writes the .Value property.
https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1091 (or actually adds a test for it already having been fixed)
When an interface or type has [DefaultMember("Value")] and VB code explicitly accesses .Value, the converter was incorrectly stripping the member access, producing
pinstead ofp.Value.The fix (already in commit 924785a) adds
&& p.Parameters.Any()to theisDefaultPropertycheck in ConvertMemberAccessExpressionAsync. This ensures only truly indexed (parameterized) default properties are stripped, while parameterless default members like Value retain their explicit access.This commit adds a regression test covering the exact scenario from issue #1091: an interface with <DefaultMember("Value")> where VB code explicitly reads and writes the .Value property.
https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX