cmake: fix build with cmake 4.0.0#47
Merged
grdanny merged 1 commit intoimageworks:masterfrom May 14, 2025
tgurr:cmake-4.0
Merged
cmake: fix build with cmake 4.0.0#47grdanny merged 1 commit intoimageworks:masterfrom tgurr:cmake-4.0
grdanny merged 1 commit intoimageworks:masterfrom
tgurr:cmake-4.0
Conversation
lgritz
approved these changes
May 14, 2025
Member
lgritz
left a comment
There was a problem hiding this comment.
I believe this is fine as it stands.
Though the CI run reveals that, unrelated to this PR, our CI has rusted away a bit and is failing because the GHA runners themselves have broken things. We need to update the CI workflow, much like we did for other projects a couple months back, to do the trick to make the right npm still work with the old ASWF images (or just switch to newer images).
This is actually the preferred approach, particularly use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CMake >= 4.0.0 build failure: