Handle yamllint_config issues with error messages#61
Handle yamllint_config issues with error messages#61bjhargrave wants to merge 1 commit intoinstructlab:mainfrom
Conversation
If the specified yamllint_config is empty or malformed, we want to supply an appropriate error message. Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
|
seems it will show only failed msg if invalid, may no need to go next: |
I don't understand your comment. Can you be more specific? Thanks |
|
sorry, not that clear. It should only show the invalid if failed, so may no need to check it in the next step, like pattern, the for-loop. |
In the loop we have established that the list exists and is non-empty. The output will either be empty (no messages because everything was fine, so the loop will not run), a list of messages (which will match the pattern, so the elifs will be ignored), or some other message such as invalid config or a traceback due to malformed config (in this case we are in "error" mode so no need for performance concerns and the elifs return so the loop is terminated). So I think the changes in this PR are correct. |
If the specified yamllint_config is empty or malformed, we want to supply an appropriate error message.
Closes #60