Change the vue deeplink example slug with query parameters#459
Open
voortwis wants to merge 2 commits intoionic-team:mainfrom
Open
Change the vue deeplink example slug with query parameters#459voortwis wants to merge 2 commits intoionic-team:mainfrom
voortwis wants to merge 2 commits intoionic-team:mainfrom
Conversation
When using the push({ path:slug }) any query params on the url (slug) will be lost. When just pushing the slug as a string the router will also parse the query-params.
Ran into this on a redirect from keycloak.
Fixed the correct router.push(slug). example for vue
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By changing the router.push(...) to string format the router will also parse the query parameters from the url, like we have on a redirect from keycloak.