fix(filesystem): progress notification for the last chunk#2359
Closed
akdasa wants to merge 1 commit intoionic-team:mainfrom
Closed
fix(filesystem): progress notification for the last chunk#2359akdasa wants to merge 1 commit intoionic-team:mainfrom
akdasa wants to merge 1 commit intoionic-team:mainfrom
Conversation
Contributor
|
Hey @akdasa, thanks for this PR. The Should you run into any other issues, feel free to open an issue at https://github.com/ionic-team/capacitor-file-transfer I'll be closing this PR. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The progress notification might not be triggered when a file finishes downloading if it completes too quickly due to the time-based threshold logic. As a result, the client may never receive a progress update showing 100% completion (it often stops at something like 98.1234%).
This PR ensures that the progress notification is sent when the file has fully downloaded, guaranteeing the client receives an update with 100% progress.
Improvements to progress update logic:
filesystem/ios/Sources/FilesystemPlugin/Filesystem.swift: AddedisTimeToEmitandisLastChunkvariables to clarify the conditions for emitting progress updates. This ensures that progress is emitted either when the time threshold (0.1seconds) is reached or when the operation is complete (totalBytesWritten == totalBytesExpectedToWrite).