Introduce flexible height by proportially sizing elements#1302
Open
polyclick wants to merge 1 commit intokernc:masterfrom
Open
Introduce flexible height by proportially sizing elements#1302polyclick wants to merge 1 commit intokernc:masterfrom
polyclick wants to merge 1 commit intokernc:masterfrom
Conversation
kernc
requested changes
Oct 30, 2025
| drawdown_height = int(base_height * 0.2) # was 80px | ||
| pl_height = int(base_height * 0.2) # was 80px | ||
| volume_height = int(base_height * 0.175) # was 70px | ||
| indicator_height = int(base_height * 0.125) # was 50px |
Owner
There was a problem hiding this comment.
I don't like that these are fixed proportions, and that's that.
Maybe we could make param plot_height: int | Tuple[int] | Dict[str, int]? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's user set a hardcoded value for the main OHLC chart, will proportially resize other sections.