-
Notifications
You must be signed in to change notification settings - Fork 1.3k
docs: prevent header tabs from overlapping on search expand #6556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for knative ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jijo-OO7 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @jijo-OO7 I don't think you have actually followed the issue discussion, read it then open the PR. |
|
This is totally mis-aligned from what @dprotaso described there. |
|
Yeah I don't see any difference on Chrome Desktop. |
|
Note the idea is for the home, docs etc in the top row to not move when the search bar has focus |
|
Thanks for the pointer. I’ve re-read the original issue discussion and I see where the intent differs from the current implementation. |
|
Hi @dprotaso Updated the implementation based on your feedback. The top navigation now remains static when search gains focus by moving to a separate sticky container, following the Material for MkDocs pattern. Would appreciate your review to ensure this matches the intended behavior. Let me know if any further adjustments are needed. |
|
@jijo-OO7 I am not sure if this is what was described? the before version is not complete, initially there were elements in nav beside the search bar, which have been removed in after version, |
|
Final review to @dprotaso . Does not seem optimal to me. |
@jijo-OO7 Again, you did not follow the issue discussion, as Far as I know the nav elements were described to be overlayed by search bar expansion and not removed. |
|
@dprotaso Could you try reloading the preview? The navigation elements remain visible on my local build and the search expands as expected per the Material for MkDocs pattern. A cache refresh might resolve any discrepancies. |
|
I would expect |
|
Got it, thank you for clarifying. I understand now, the navigation items should remain aligned on the same horizontal line as the search bar. I'll revisit the implementation to ensure proper alignment and will push an updated commit shortly with Home, Docs, About, Blog, and Community properly aligned alongside the search bar. |


Header tabs overlap when search expands [Fixes #6332]
BEFORE
Proposed Changes
Reference: https://squidfunk.github.io/mkdocs-material/tutorials/
AFTER