Added func subscribe support to raw deployer by 24aysh · Pull Request #3335 · knative/func

24aysh · 2026-01-07T20:15:04Z

Changes

🎁 Add new feature - Event subscriptions now work with --deployer raw

Summary

This PR implements Knative Trigger creation for the raw Kubernetes deployer

What Changed

Modified File: pkg/k8s/deployer.go

/kind enhancement

Fixes #3272

Release Note

Event subscriptions now work with raw Kubernetes deployer (`--deployer raw`).

Signed-off-by: ayush <ayushkumar2122.ak@gmail.com>

linux-foundation-easycla · 2026-01-07T20:15:12Z

The committers listed above are authorized under a signed CLA.

✅ login: 24aysh / name: ayush (0e28e17, 4b87f9e, 660161a)

knative-prow · 2026-01-07T20:15:14Z

Welcome @24aysh! It looks like this is your first PR to knative/func 🎉

knative-prow · 2026-01-07T20:15:14Z

Hi @24aysh. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

intojhanurag · 2026-01-08T08:31:25Z

/ok-to-test

Signed-off-by: ayush <ayushkumar2122.ak@gmail.com>

pkg/k8s/deployer.go

matejvasek · 2026-01-13T17:39:55Z

It would be neat to have some tests for this.

24aysh · 2026-01-13T17:44:54Z

It would be neat to have some tests for this.

sure i'll add them

codecov · 2026-01-13T17:47:45Z

Codecov Report

❌ Patch coverage is 62.60870% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.57%. Comparing base (4f9f7b8) to head (0e28e17).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/k8s/deployer.go	62.60%	34 Missing and 9 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3335      +/-   ##
==========================================
+ Coverage   55.47%   55.57%   +0.09%     
==========================================
  Files         173      173              
  Lines       20112    20225     +113     
==========================================
+ Hits        11158    11240      +82     
- Misses       7833     7857      +24     
- Partials     1121     1128       +7

Flag	Coverage Δ
e2e	`40.89% <74.72%> (+1.29%)`	⬆️
e2e go	`35.16% <0.00%> (-0.22%)`	⬇️
e2e node	`30.97% <0.00%> (-0.20%)`	⬇️
e2e python	`34.67% <0.00%> (-0.24%)`	⬇️
e2e quarkus	`31.12% <0.00%> (-0.20%)`	⬇️
e2e rust	`30.52% <0.00%> (-0.20%)`	⬇️
e2e springboot	`28.94% <0.00%> (-0.23%)`	⬇️
e2e typescript	`31.09% <0.00%> (-0.20%)`	⬇️
integration	`18.61% <15.38%> (-0.02%)`	⬇️
unit macos-14	`44.51% <13.18%> (-0.18%)`	⬇️
unit macos-latest	`44.51% <13.18%> (-0.18%)`	⬇️
unit ubuntu-24.04-arm	`44.64% <13.91%> (-0.18%)`	⬇️
unit ubuntu-latest	`45.39% <13.18%> (-0.18%)`	⬇️
unit windows-latest	`44.53% <13.18%> (-0.18%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

matejvasek · 2026-01-14T16:26:26Z

It would be neat to have some tests for this.

sure i'll add them

btw I think @Kunal1522 works on subscription tests here #3324 maybe you can re-use that.

24aysh · 2026-01-14T16:28:43Z

It would be neat to have some tests for this.

sure i'll add them

btw I think @Kunal1522 works on subscription tests here #3324 maybe you can re-use that.

cool, i'll take a look, i will do that within 1-2 days, right now i'm busy with my college stuff

24aysh · 2026-01-18T12:59:26Z

/test unit-tests

24aysh · 2026-01-18T13:13:16Z

cc @matejvasek

24aysh · 2026-01-21T19:41:43Z

ready for review @gauron99 @lkingland

24aysh · 2026-01-21T19:55:55Z

/retest

gauron99 · 2026-01-22T08:24:53Z

pkg/k8s/deployer.go

+	// Delete stale triggers
+	for _, trigger := range existingTriggers.Items {
+		// Only delete triggers we manage
+		if trigger.Annotations[managedByAnnotation] == managedByValue {


is there a function name annotation as well here? because if there are 100 functions on cluster, they would all have this managedBy Annotation IIUC? We would be checking multiple functions here and they could have the same trigger name? OR (more probable) we would delete triggers from different functions?

yeah that's a flaw here, i need to update it

was this fixed?

i did that change that in 660161a

matejvasek · 2026-01-26T16:03:23Z

pkg/k8s/deployer.go

+
+		for _, sub := range f.Deploy.Subscriptions {
+			attributes := make(map[string]string)
+			maps.Copy(attributes, sub.Filters)


Why do we need copy? Are there some hidden mutations?

matejvasek · 2026-01-26T17:30:24Z

pkg/k8s/deployer_test.go

+	broker := "default"
+
+	// Same filters, different order
+	filters1 := map[string]string{


I think his test is all right. Just a note:

Go maps have randomized hashing to avoid DoS on memory. As a result the ordering is random.

Probability you end up with all (key order wise) identical maps is cca 2.78%. So there is 2.78% chance this test will pass even if generateTriggerName() does not internally sort keys.

matejvasek · 2026-01-26T18:25:37Z

/approve
/lgtm
/hold for @gauron99

knative-prow · 2026-01-26T18:26:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24aysh, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

matejvasek · 2026-01-26T18:48:10Z

/unhold

added subscribe in raw deployment

51a57ac

Signed-off-by: ayush <ayushkumar2122.ak@gmail.com>

knative-prow bot added the kind/enhancement label Jan 7, 2026

knative-prow bot requested review from dsimansk and jrangelramos January 7, 2026 20:15

knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 7, 2026

knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2026

remove hardcoded vals

42352cd

Signed-off-by: ayush <ayushkumar2122.ak@gmail.com>

intojhanurag reviewed Jan 10, 2026

View reviewed changes

pkg/k8s/deployer.go Outdated Show resolved Hide resolved

added unit tests

3968256

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2026

added e2e tests

4082656

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2026

knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2026

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2026

24aysh requested a review from intojhanurag January 18, 2026 13:37

knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 21, 2026

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2026

24aysh requested a review from gauron99 January 21, 2026 20:03

gauron99 reviewed Jan 22, 2026

View reviewed changes

add fn filter in state management

660161a

24aysh force-pushed the func-subscribe branch from 5243ea9 to 660161a Compare January 22, 2026 13:40

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2026

Merge branch 'main' into func-subscribe

4b87f9e

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2026

gauron99 requested review from lkingland and matejvasek and removed request for dsimansk and jrangelramos January 22, 2026 13:44

fixes

0e28e17

matejvasek reviewed Jan 26, 2026

View reviewed changes

knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2026

knative-prow bot assigned matejvasek Jan 26, 2026

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2026

matejvasek requested a review from gauron99 January 26, 2026 18:25

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2026

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2026

knative-prow bot merged commit 61ed502 into knative:main Jan 26, 2026
43 checks passed

creydr mentioned this pull request Jan 29, 2026

Kubernetes raw deployer requires knative #3404

Closed

Conversation

24aysh commented Jan 7, 2026

Changes

Summary

What Changed

Release Note

Uh oh!

linux-foundation-easycla bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

knative-prow bot commented Jan 7, 2026

Uh oh!

knative-prow bot commented Jan 7, 2026

Uh oh!

intojhanurag commented Jan 8, 2026

Uh oh!

Uh oh!

matejvasek commented Jan 13, 2026

Uh oh!

24aysh commented Jan 13, 2026

Uh oh!

codecov bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

matejvasek commented Jan 14, 2026

Uh oh!

24aysh commented Jan 14, 2026

Uh oh!

24aysh commented Jan 18, 2026

Uh oh!

24aysh commented Jan 18, 2026

Uh oh!

24aysh commented Jan 21, 2026

Uh oh!

24aysh commented Jan 21, 2026

Uh oh!

gauron99 Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

24aysh Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

matejvasek Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

24aysh Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matejvasek Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

matejvasek Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matejvasek commented Jan 26, 2026

Uh oh!

knative-prow bot commented Jan 26, 2026

Uh oh!

matejvasek commented Jan 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

linux-foundation-easycla bot commented Jan 7, 2026 •

edited

Loading

codecov bot commented Jan 13, 2026 •

edited

Loading

24aysh Jan 26, 2026 •

edited

Loading

matejvasek Jan 26, 2026 •

edited

Loading