Skip to content

Return pruned entry count from prune_live_chain() #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MegaRedHand merged 1 commit into from
Feb 27, 2026
+10 −6
Merged

Return pruned entry count from prune_live_chain() #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions crates/storage/src/store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,15 +367,15 @@ impl Store {
if let Some(finalized) = checkpoints.finalized
&& finalized.slot > old_finalized_slot
{
self.prune_live_chain(finalized.slot);
let pruned_chain = self.prune_live_chain(finalized.slot);

// Prune signatures and payloads for finalized slots
let pruned_sigs = self.prune_gossip_signatures(finalized.slot);
let pruned_payloads = self.prune_aggregated_payloads(finalized.slot);
if pruned_sigs > 0 || pruned_payloads > 0 {
if pruned_chain > 0 || pruned_sigs > 0 || pruned_payloads > 0 {
info!(
finalized_slot = finalized.slot,
pruned_sigs, pruned_payloads, "Pruned finalized signatures"
pruned_chain, pruned_sigs, pruned_payloads, "Pruned finalized data"
);
}
}
Expand Down Expand Up @@ -419,7 +419,9 @@ impl Store {
///
/// Blocks/states are retained for historical queries, only the
/// LiveChain index is pruned.
pub fn prune_live_chain(&mut self, finalized_slot: u64) {
///
/// Returns the number of entries pruned.
pub fn prune_live_chain(&mut self, finalized_slot: u64) -> usize {
let view = self.backend.begin_read().expect("read view");

// Collect keys to delete - stop once we hit finalized_slot
Expand All @@ -436,15 +438,17 @@ impl Store {
.collect();
drop(view);

if keys_to_delete.is_empty() {
return;
let count = keys_to_delete.len();
if count == 0 {
return 0;
}

let mut batch = self.backend.begin_write().expect("write batch");
batch
.delete_batch(Table::LiveChain, keys_to_delete)
.expect("delete non-finalized chain entries");
batch.commit().expect("commit");
count
}

/// Prune gossip signatures for slots <= finalized_slot.
Expand Down