Skip to content

Conversation

@tanderson-ld
Copy link
Contributor

@tanderson-ld tanderson-ld commented Jan 28, 2026

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Note

Medium Risk
Changes affect initialization and offline data source selection, which can alter client connectivity/status behavior. Persistence propagation tweaks also impact whether updates are written to persistent stores.

Overview
FDv2 now behaves cleanly in offline and no-source configurations. FDv2DataSystem builds an externalUpdatesOnly data source when config.offline is true, and FDv2DataSource explicitly marks the client VALID (with a log) when there are no initializers/synchronizers instead of trying to connect.

Persistence signaling is now consistently propagated. DataSourceSynchronizerAdapter includes shouldPersist when converting FDv1 init payloads into FDv2 ChangeSets and defaults FDv1 upsert conversions to persist, while WriteThroughStore simplifies/guards persistent-store calls using hasPersistence.

Adds a regression test to ensure an offline client using the FDv2 data system initializes successfully and reports VALID status.

Written by Cursor Bugbot for commit 6ae877b. This will update automatically on new commits. Configure here.

@tanderson-ld tanderson-ld marked this pull request as ready for review January 29, 2026 20:56
@tanderson-ld tanderson-ld requested a review from a team as a code owner January 29, 2026 20:56
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@tanderson-ld tanderson-ld merged commit 6804e26 into main Jan 30, 2026
23 of 24 checks passed
@tanderson-ld tanderson-ld deleted the ta/SDK-1611/daemon-mode-offline-mode branch January 30, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants