-
Notifications
You must be signed in to change notification settings - Fork 11
chore: handles offline mode, no initializers nor synchronizers #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+42
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/java-core into rlamb/fallback-and-recovery
…o ta/SDK-1611/verifying-daemon-mode
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/WriteThroughStore.java
Outdated
Show resolved
Hide resolved
lib/sdk/server/src/test/java/com/launchdarkly/sdk/server/FDv2DataSourceTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/FDv2DataSystem.java
Show resolved
Hide resolved
kinyoklion
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Note
Medium Risk
Changes affect initialization and offline data source selection, which can alter client connectivity/status behavior. Persistence propagation tweaks also impact whether updates are written to persistent stores.
Overview
FDv2 now behaves cleanly in offline and no-source configurations.
FDv2DataSystembuilds anexternalUpdatesOnlydata source whenconfig.offlineis true, andFDv2DataSourceexplicitly marks the clientVALID(with a log) when there are no initializers/synchronizers instead of trying to connect.Persistence signaling is now consistently propagated.
DataSourceSynchronizerAdapterincludesshouldPersistwhen converting FDv1initpayloads into FDv2ChangeSets and defaults FDv1upsertconversions to persist, whileWriteThroughStoresimplifies/guards persistent-store calls usinghasPersistence.Adds a regression test to ensure an offline client using the FDv2 data system initializes successfully and reports
VALIDstatus.Written by Cursor Bugbot for commit 6ae877b. This will update automatically on new commits. Configure here.