ci(contract-test-utils): consolidating test websocket implementation#1193
Open
ci(contract-test-utils): consolidating test websocket implementation#1193
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
joker23
force-pushed
the
skz/sdk-2010/contract-test-share
branch
from
03c4541 to
47e104b
Compare
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
joker23
force-pushed
the
skz/sdk-2010/contract-test-share
branch
from
47e104b to
85c21bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk because changes are confined to contract-test tooling and SDK contract-test entities, mainly refactoring to a shared implementation. Main risk is behavioral drift in websocket message handling/capabilities wiring that could break contract tests across environments.
Overview
Consolidates contract-test websocket handling into a shared
TestHarnessWebSocketexported from@launchdarkly/js-contract-test-utils/client, making capabilities and client-entity creation injectable.Browser and React Native contract-test entities are updated to use the shared implementation (browser via a thin subclass with fixed capabilities; React Native by passing capabilities,
newSdkClientEntity, and the connection-state callback).Written by Cursor Bugbot for commit 85c21bc. This will update automatically on new commits. Configure here.