Remove duplicate @sistent/mui-datatables causing npm install failure#1228
Merged
fitzergerald merged 2 commits intomasterfrom Jan 16, 2026
Merged
Remove duplicate @sistent/mui-datatables causing npm install failure#1228fitzergerald merged 2 commits intomasterfrom
fitzergerald merged 2 commits intomasterfrom
Conversation
This package was causing npm dependency resolution conflicts after PR #1218 switched to the GitHub fork of mui-datatables. The code now uses the 'mui-datatables' package from github:leecalcote/mui-datatables, so the old @sistent/mui-datatables package in devDependencies is no longer needed. Co-authored-by: fitzergerald <182300328+fitzergerald@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix build error in CI pipeline
Remove duplicate @sistent/mui-datatables causing npm install failure
Jan 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical npm install failure caused by duplicate mui-datatables dependencies. After PR #1218 introduced the GitHub fork of mui-datatables, the old @sistent/mui-datatables package remained in devDependencies, creating ERESOLVE conflicts due to incompatible peer dependency constraints between the two packages.
Changes:
- Removed duplicate
@sistent/mui-datatablesfrom devDependencies in package.json - Updated package-lock.json to reflect the removal and consolidate to the GitHub fork
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Removed @sistent/mui-datatables from devDependencies to eliminate duplicate dependency conflict |
| package-lock.json | Removed @sistent/mui-datatables node_modules entry, updated mui-datatables to GitHub fork reference, and updated tss-react to v4.9.20 as a transitive dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1218 switched to the GitHub fork of mui-datatables but left the old
@sistent/mui-datatablespackage in devDependencies, causing npm to fail with ERESOLVE conflicts due to incompatible peer dependency constraints.Changes
@sistent/mui-datatablesfrom devDependencies in package.jsonThe codebase now uses only
mui-datatables: github:leecalcote/mui-datatables#decbb0493fdd95d674d2dd748d3d35cefb801195from dependencies.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.