Conversation
|
First of all, great job, that's an amazing addition. |
|
@LostRuins has been adding support to Koboldcpp for the past few days, via ServeurpersoCom/acestep.cpp. |
|
My 2c is that ace step is probably out of scope for this project being that it also requires an LM pass for the planner phase, and deals with audio rather than images/video. But I might be biased seeing that I've already got ace step working via ace-step.cpp, seems unnecessary to reinvent the wheel. |
|
Great job! However, I think this goes a bit beyond the intended scope of sd.cpp. It might be better to make it a separate repository, perhaps called ace-step.cpp. |
|
Alright then I’ll close this PR. Since https://github.com/ServeurpersoCom/acestep.cpp exists (which I wasn’t aware of when I started working on this), I think I’ll drop this and may contribute there if I have something relevant to add |
This PR add initial support for ACE-Step-1.5
CLI eg:
Generates 120s of audio in under 12s on an RTX 4090
Download the model: https://huggingface.co/Comfy-Org/ace_step_1.5_ComfyUI_files/blob/main/checkpoints/ace_step_1.5_turbo_aio.safetensors
Required ggml submodule for now: https://github.com/rmatif/ggml/tree/ace
Since this is a text-to-music model and it introduces significant changes and new code, I’m wondering whether it’s preferable to integrate it into stable-diffusion.cpp, or if it would be better for me to create a separate repo (e.g ace.cpp) dedicated to this. @leejet any thoughts?
Output example:
output.mp4