Open
Conversation
There was a problem hiding this comment.
Pull request overview
Removes legacy/dead platform conditionals from TinyXML-2’s headers/source to simplify platform-specific compilation paths.
Changes:
- Removed
__BORLANDC__,__QNXNTO__,__CC_ARM, and WinCE-related conditional compilation branches. - Simplified platform-specific include selection to primarily special-case
ANDROID_NDK. - Adjusted Windows file seek/tell macro selection to key off
_MSC_VERand removed legacy fallback code paths.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tinyxml2.h | Drops legacy platform conditionals and removes an outdated build/formatting comment block. |
| tinyxml2.cpp | Removes legacy compiler/platform branches, simplifies fallthrough/sn* macro logic, and tweaks file seek/tell platform selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| _charBuffer = 0; | ||
| _parsingDepth = 0; | ||
|
|
||
There was a problem hiding this comment.
Line contains stray whitespace on an otherwise blank line. This can cause noisy diffs and may violate whitespace/formatting checks; remove the trailing spaces (leave it as a truly empty line or delete the blank line).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Too many long dead platforms still in the source code.