Open
Conversation
* `Rule` nodes have now been renamed to `Declaration` so the visitRule was not firing * `URLNode.currentFileInfo` no longer exists and is replaced by `URLNode.fileInfo()`
chandansamanta
approved these changes
Apr 11, 2019
chandansamanta
left a comment
chandansamanta
left a comment
There was a problem hiding this comment.
Looks good for me, even I have faced the same issue. Should be merged to master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a custom plugin based on this in one of our projects and it took a while to work out why it was no longer working with Less 3.x - there have been some changes to the Tree API that aren't (or don't seem to be) fully documented.
I haven't tested this change specifically with this plugin, since ours does something slightly different - in particular I don't know if the
less.tree.Call("data-uri"call actually works as we just do a string replacement on the URL value itself.